search

libretro / snes9x

Snes9x - Portable Super Nintendo Entertainment System (TM) emulator
http://www.snes9x.com
Other
46 stars 55 forks source link

Cannot open 8MB ROM files #294

Closed mikairan closed 1 year ago

mikairan commented 1 year ago

Title is self-explanatory, the 'Snes9x - Current' core cannot open 8 megabyte ROM files. I understand that there were no official SNES games released that had a size of 8MB, but there are 2 important things to note:

  1. The original, standalone version of Snes9x has been able to open and run 8MB ROM's for many years, without any issue.
  2. All of the other SNES cores provided with Retroarch are able to successfully load 8MB ROM's without problems.

I don't know why this one specific core is unable to load 8MB ROM's, considering both the standalone version as well as the other libretro cores are able to. When attempting to load an 8MB ROM from the main menu, it simply kicks you back with the message "Failed to load content." However, if you try to open an 8MB ROM from file explorer using the dropdown menu, Retroarch just crashes entirely and the program closes itself.

A fix for this would really be appreciated, as Snes9x is the only SNES core that my PC is able to run without lagging immensely.

ds22x commented 1 year ago

Fixed via https://github.com/libretro/snes9x/commit/a65f5e2bf3c07d96b1b762fd16f9bf0829cbc351

KamiLordus commented 1 year ago

@ds22x Why are new fix added to the old version 1.61 (Snes9x current Libretro) when version 1.62.3 has been available for some time? Core downgraded to an older version for some reason?

ds22x commented 1 year ago

Because it's easy enough to implement and won't impact an eventual resync.

KamiLordus commented 1 year ago

Makes sense. Thanks for the information :)