Open DrUm78 opened 1 year ago
Software: Core compiled for armv7 32-bit and run though SDLRetro light Libretro frontend Hardware: FunKey S handheld device
While those lines fixed the sound issue in games like Star Wars serie or Mortal Kombat 2 (longered sound notes), it now breaks games like Clay Fighter 1 & 2 (battle does not start). Other impacted games are Tengai Makyou Zero (sound cut during the intro) or Earthworm Jim 2 (same during intro + some sound absent ingame): https://github.com/libretro/snes9x2005/blob/fd45b0e055bce6cff3acde77414558784e93e7d0/source/apu.c#L440-L443 The previous code did the opposite: https://github.com/libretro/snes9x2005/blob/761d752569b9bad6bdb755e91ca9e345cfb2788d/source/apu.c#L764 I think we could parse the ROM header like memmap.c does by calling this function: https://github.com/libretro/snes9x2005/blob/fd45b0e055bce6cff3acde77414558784e93e7d0/source/memmap.c#L1067
I know that this repo is based on some old code, but it's still one of the best regarding compatibility/performance for low-end devices, so it might need a few fixes on the sound part I think.
Software: Core compiled for armv7 32-bit and run though SDLRetro light Libretro frontend Hardware: FunKey S handheld device
While those lines fixed the sound issue in games like Star Wars serie or Mortal Kombat 2 (longered sound notes), it now breaks games like Clay Fighter 1 & 2 (battle does not start). Other impacted games are Tengai Makyou Zero (sound cut during the intro) or Earthworm Jim 2 (same during intro + some sound absent ingame): https://github.com/libretro/snes9x2005/blob/fd45b0e055bce6cff3acde77414558784e93e7d0/source/apu.c#L440-L443 The previous code did the opposite: https://github.com/libretro/snes9x2005/blob/761d752569b9bad6bdb755e91ca9e345cfb2788d/source/apu.c#L764 I think we could parse the ROM header like memmap.c does by calling this function: https://github.com/libretro/snes9x2005/blob/fd45b0e055bce6cff3acde77414558784e93e7d0/source/memmap.c#L1067
I know that this repo is based on some old code, but it's still one of the best regarding compatibility/performance for low-end devices, so it might need a few fixes on the sound part I think.