Cleanups and bug fixes - Githubissues

libretro / snes9x2010

Snes9x 2010. Port of Snes9x 1.52+ to Libretro (previously called SNES9x Next). Rewritten in C and several optimizations and speedhacks.

Other

98 stars 70 forks source link

Cleanups and bug fixes #130

Closed deltabeard closed 4 years ago

deltabeard commented 4 years ago

This pull request fixes the following issues:

https://github.com/libretro/snes9x2010/issues/89 Black screen on 6MiB Super Mario World ROM hack.
https://github.com/libretro/snes9x2010/issues/102 Use of printf in logging

Overscan is removed within these series of changes. This is a work-around to the following overscan related issues:

Further work:

All unused configuration options are removed.
Fixed some compiler warnings.
Removed unused code sections.
Modified pitch calculation. Considering the width and height of the framebuffer is given, the pitch should be a function of the width. Let me know if this is incorrect.

All these items have been tested with RetroArch.

Many thanks.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert and fixes 1 when merging 68c97327faef970ea87b967bd4f4bbed575bbf57 into ba9f2240360f8db270fb6ba5465c79c317070560 - view on LGTM.com

new alerts:

1 for Local variable hides global variable

fixed alerts:

1 for FIXME comment

lgtm-com[bot] commented 4 years ago

This pull request fixes 1 alert when merging 460a622bc064525c70fee9e26c1756915588c42d into ba9f2240360f8db270fb6ba5465c79c317070560 - view on LGTM.com

fixed alerts:

1 for FIXME comment

Tatsuya79 commented 4 years ago

What's going on in libretro_coreoptions.h? It seems there was a Turkish translation coming from the other updated main core (options named snes9x*).

Only the options named snes9xnext* are the actual valid variables used in libretro.c.

You made the wrong ones from that Turkish part the new US v2 options which should be reverted.

deltabeard commented 4 years ago

I missed that. I'll also remove the unused options for the Turkish translation. It beggars the question why it was merged in the first place though.

lgtm-com[bot] commented 4 years ago

This pull request fixes 1 alert when merging 21f7f00d4ac9fafea9d4b8b5e22948b0451e6385 into ba9f2240360f8db270fb6ba5465c79c317070560 - view on LGTM.com

fixed alerts:

1 for FIXME comment

deltabeard commented 4 years ago

Fixed the config options, and tested them in RetroArch.

lgtm-com[bot] commented 4 years ago

This pull request fixes 1 alert when merging dc4ae05a4e3430c1408ce5d290331167b070acb9 into ba9f2240360f8db270fb6ba5465c79c317070560 - view on LGTM.com

fixed alerts:

1 for FIXME comment

deltabeard commented 4 years ago

Thank you! Please close the four issues. :smiley: