search

libretro / snes9x2010

Snes9x 2010. Port of Snes9x 1.52+ to Libretro (previously called SNES9x Next). Rewritten in C and several optimizations and speedhacks.
Other
98 stars 70 forks source link

Increase SRAM size #147

Closed cout closed 2 years ago

cout commented 3 years ago

For save states to work in the Super Metroid practice hack, SRAM size needs to be increased to 0x80000. This change has already been made in snes9x and has been working well (https://github.com/snes9xgit/snes9x/issues/637). In snes9x accessing SRAM beyond $71FFFF was causing undefined behavior due to lack of bounds checking; at a glance, it looks like the same problem exists in snes9x2010. Increasing SRAM size eliminates the UB without requiring bounds checking.

inactive123 commented 3 years ago

Alright, if it has no negative consequences I'd be fine with merging any PR that gets sent our way.

cout commented 3 years ago

Sounds good, I'll try to get a PR together this week.