search

libretro / snes9x2010

Snes9x 2010. Port of Snes9x 1.52+ to Libretro (previously called SNES9x Next). Rewritten in C and several optimizations and speedhacks.
Other
98 stars 71 forks source link

User device type not being reloaded #91

Closed Jzooor closed 7 years ago

Jzooor commented 7 years ago

I am running Snes9x 2010 1.52.4 7d25113 on an RPI3. Playing games that use the SNES Mouse (my daughter likes Mario Paint and the Mario Early Years games), I can switch the user device type in the quick menu controls menu to SNES Mouse and the mouse works properly. However if I save a game remap file and exit/restart the ROM, the setting will have gone back to SNES Joypad and not reload my mouse selection.

This worked properly back when the core was still snes9x-next.

Jzooor commented 7 years ago

To clarify, the device type is being saved in the remap file, but not reloaded when starting the ROM. I checked in the file and the line "input_libretro_device_p1 = "2"" is present. Trying to load the game remap file manually from the quick menu does nothing to update the selected device type either.

andres-asm commented 7 years ago

uh... remaps don't store the device type

Jzooor commented 7 years ago

So what is "input_libretro_device_p1" in the remap file for then?

andres-asm commented 7 years ago

You should be running a really old build. Those paremeters aren't being added and that hasn't been the case for a while.

The parameter could still be there from an old nightly experiment or something.

Jzooor commented 7 years ago

The remap files may have been created while the core was snes9x-next, so perhaps somewhere along the line there was a regression and that feature was lost.

On Sun, Jan 29, 2017, 10:43 Andrés notifications@github.com wrote:

You should be running a really old build. Those paremeters aren't being added and that hasn't been the case for a while.

The parameter could still be there from an old nightly experiment or something.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/libretro/snes9x2010/issues/91#issuecomment-275926531, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGRlQcCFyfSzYdMZfCfoFTvZ1VLm0XUks5rXMGygaJpZM4Lw1HM .

andres-asm commented 7 years ago

It was a test, not really a feature. I plan on adding that again but with separate flags from the main cfg

Jzooor commented 7 years ago

Well it was extremely useful to me, can you point me toward which commit removed it?

andres-asm commented 7 years ago

no idea more than a year ago

Jzooor commented 7 years ago

Ah, I see where it was done upstream in retroarch. Added in Feb (67a68c0), removed in Nov (281aa1d).

It was incredibly useful; saved me from having to change settings when my kid wanted to play and kept me from having to describe how to do it to the wife when I'm not around.

I'll see if I can manage to use some rom specific config files to apply the setting.