search

libretro / swanstation

GNU General Public License v3.0
93 stars 21 forks source link

[Bug]Analog mode combo needs a delay option like Beetle #77

Closed Immersion95 closed 11 months ago

Immersion95 commented 11 months ago

When doing the combo for the analog mode, it is changing with the speed of light.

DarthMew commented 11 months ago

I've looked into this before, but the toggle works fine on my end using a regular set of controllers on Windows (Xbox, DualShock, Dualsense etc.) without it rapid firing (as previously discussed in https://github.com/libretro/swanstation/issues/4), so I'm closing this until someone can precisely identify why this happens to some people in the first place.

As for a hold delay for the toggle, I'm not going to look into it myself, but a PR implementing it is always welcome.

Immersion95 commented 11 months ago

Found the culprit and how to reproduce it on your end. When you choose Analog controller for : Port 1 only -->OK Port 1 + Port 2 or 3 or whatever -->Rapid fire

If that is solved, the delay won't be needed of course :).

DarthMew commented 11 months ago

Thank you for pinpointing it. Now to figure out how to block the rapid firing.

DarthMew commented 11 months ago

https://github.com/libretro/swanstation/commit/9a88828f8bb7d4db891ff3101bfa7eaac3197995 should fix it.