search

libretro / vba-next

Optimized port of VBA-M to Libretro.
GNU General Public License v2.0
94 stars 88 forks source link

[PS VITA] Golden sun effects missing #104

Open HammerD72 opened 5 years ago

HammerD72 commented 5 years ago

In battle when using psynergy or summons, the magic effects are simply invisible.

Using the latest Playstation Vita nightly as of this post. Vba next 1.0.2 110ab08

I tried the latest stable (1.7.3) and the effects are visible but retroarch crashes when using summons.

ghost commented 5 years ago

it could either be one of many tweaks thats enabled for VITA, including frameskip. i fixed one gfx-related tweak thats causing a crash for summons as you have said.

if you still have your vita, can you capture a vid of these missing effects and the settings used?

searzh commented 4 years ago

The issue is still there. I will make a video ASAP. I love this emulator because other than the effects missing it runs Golden Sun almost perfectly.

Edit: Here's the video https://photos.app.goo.gl/aEjpR14S7hBK86t18 and the video config https://photos.app.goo.gl/5wq7VMMLURyVxyNs5

searzh commented 4 years ago

Is this project no longer being maintained?

negativeExponent commented 4 years ago

whats wrong with other gba cores running Golden Sun?

anyways missing effects as well in Summon Nights 2. noticeable during crafting, when done it will only show white flash

@matthewbauer I sent a PR that at least fixed missing visual effects in Summon Nights 2 that i noticed. Might probably fix these missing effects in Golden Sun as well.

If you can provide savestate and savefile just incase this problem is still not fixed after the PR is merge, i would look more into it when i have time.

searzh commented 4 years ago

whats wrong with other gba cores running Golden Sun?

AFAIK they don't run the game full speed. But will double check and come back to you.

I sent a PR that at least fixed missing visual effects in Summon Nights 2 that i noticed. Might probably fix these missing effects in Golden Sun as well.

Awesome, hopefully the original dev will check this. If he doesn't, any chance you could push these changes somewhere else?

negativeExponent commented 4 years ago

you can check from my repo and compile it. are you using this on Vita as well? coz that should where the can have be significantly faster. https://github.com/negativeExponent/vba-next/tree/fix_missing_effects

searzh commented 4 years ago

you can check from my repo and compile it.

Gonna have to google how to do that, but thanks.

are you using this on Vita as well?

Yes I am! 👯‍♂

negativeExponent commented 4 years ago

@herrmartell the PR has been merged. it should be now available in online updater or on the buildbot site. if problems still exist, send me the save file AND save state for golden sun thats near the affected area. I could play it myself, but im in the middle of Summon Nights 2 atm :D

negativeExponent commented 4 years ago

this should be working now. no more invisible effects.

Screenshot_2019-09-06_23-35-38

negativeExponent commented 4 years ago

i guess this should already have been fixed.. unless someone can confirm that it is not...

searzh commented 4 years ago

I can confirm this has been fixed. Thank you very much, and great job.

negativeExponent commented 4 years ago

thanks for the confirmation. since this is for Golden Sun and DJinn summon on Vita, i guess this crash issue is solved and can be closed as well...

(PS VITA) - Golden Sun (S)(Independent) - Crash Invoke Djinn #78

Testsr commented 4 years ago

close it.

negativeExponent commented 3 years ago

this should be safe to close now @twinaphex @hizzlekizzle