libretro / vba-next

Optimized port of VBA-M to Libretro.
GNU General Public License v2.0
96 stars 88 forks source link

Issue with loading EEPROM64K(8kb) save files #83

Open Uvik opened 7 years ago

Uvik commented 7 years ago

With the vba_next_libretro core in Retroarch, it looks like 8kb EEPROM64K save files (the name might be wrong, my apologies in advance) are not properly loaded.

Upon save, the emulator overwrites the original 8192b save file with an empty one weighing 139264 bytes.

Reliably reproduced the issue with the latest vbam_libretro core as well, but both mgba_libretro and the latest standalone release of VBA-M (taken from commit 2e8bee1) load my save files just fine.

Attached is a log file retrieved when trying to open an affected ROM and save with vba_next_libretro. Given that all logs seem RetroArch-related, I am not sure the information will be of use, but I suppose it is worth a shot anyway. log.txt

It might be important to add that I got these issues by loading my own GBA ROMs and save files, dumped from my original cartridges using a DS linked and a backup tool. Coming straight from the cartridges, they are completely unaltered.

I noticed the issue with the following ROMs (with the names retrieved by the backup tool, just in case):

All of them use the same 8kb EEPROM64K save format.

Please let me know if you require any information. I am obviously uncomfortable with sharing the ROMs I dumped, but I can provide problematic save files if required.

Thank you in advance !

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/46855877-issue-with-loading-eeprom64k-8kb-save-files?utm_campaign=plugin&utm_content=tracker%2F1027743&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1027743&utm_medium=issues&utm_source=github).
negativeExponent commented 4 years ago

this should be possilbe by using overrides from vbam-libretro to determine correct save types and save size. BUT doing so will break the current save format workaround used in this core, so i dont mind backporting those if breaking current compatibility is not an importance....

similar core that uses the save-format workaroung is beetle_gba (https://github.com/libretro/beetle-gba-libretro)

cybardev commented 1 year ago

Is there a way to export proper battery saves from this core for the aforementioned games, or nothing yet?

Or, since I have a VBA-Next save state, is there any way I can transfer my progress to the mGBA core?