libretro / vice-libretro

Versatile Commodore 8-bit Emulator
GNU General Public License v2.0
40 stars 70 forks source link

[VITA] Strange hissing/crackling issue with the sound #402

Closed 16mpx closed 2 years ago

16mpx commented 3 years ago

Hi,

I have not updated the retroarch for a while and when I did it lately, I am having a strange hissing and crackling issue with the sound with vice c64 core for Vita. Before, it was version 3.3 and the sound was ok, and now it is version 3.5 built 8b5df00 and sound has the defined issue. Any parameters I can fine tune in the sound settings to fix this ?

sonninnos commented 3 years ago

Please provide a recording of it, since it isn't happening on any hardware I have.

Also try renaming the old opt, as in try starting with fresh defaults, and post verbose log.

16mpx commented 3 years ago

Please check the below link for the sample recording.

https://youtu.be/O34JjdDFRpg

I am also attaching a verbose log with a fresh opt file.

retroarch2021_07_1721_53_09.log

sonninnos commented 3 years ago

Sure sounds weird. And it still manages to deliver full framerate? Same with NTSC?

Not very likely that some parts of the emulation became more accurate and demanding during that time in a way that a small overclock would cover it, so perhaps something is up with the revised audio buffer..

Does the sound sample rate core option and/or trying FastSID make any difference?

16mpx commented 3 years ago

Nothing wrong with the framerate, and same with NTSC.

Unfortunately no difference with the FastSID engine and changing (lowering) sound sample rate also has no positive effect.

Does sound handling differs between the versions 3.3 and 3.5 ? Maybe this difference can cause the issue..

sonninnos commented 3 years ago

Yes, the codebase had big changes and also the core added support for multiple SIDs.

The output used to be always mono, but currently it is always stereo. Adding another SID will put the first one to left channel and second to right channel. So does the "SID Extra" option do anything else except that there?

16mpx commented 3 years ago

I have tried all available addresses in the "SID Extra" options menu but the effect is only to put sound to the left channel as you have mentioned, nothing changed with the sound quality unfortunately.

sonninnos commented 3 years ago

I pushed a tiny change which probably won't do anything, as it did not make it any better or worse in Windows or RPi2.

16mpx commented 3 years ago

I have tried it and you are right, sound is still same.

If you agree, I can close the issue for now.

sonninnos commented 3 years ago

No closing until it is solved.

sonninnos commented 3 years ago

Sure this is the only core that does this?

16mpx commented 3 years ago

There are other cores (like libretro-uae) that suffers because of the ps vita's performance constraints but as I mentioned earlier, this core has perfect sound before even if I underclocked vita cpu to 333 mhz but now it suffers.

sonninnos commented 3 years ago

It might be related to this one then: https://github.com/libretro/vice-libretro/issues/411

sonninnos commented 3 years ago

Have you tried other resampler settings in the frontend, most importantly quality to normal instead of default lower?

16mpx commented 3 years ago

I have changed the resampler settings to normal and nothing changed, still have the same issue.

16mpx commented 2 years ago

I have tried the latest build (81e9837) just now and audio is perfectly fine issue is gone.

sonninnos commented 2 years ago

Great! Maybe it was the audio buffer size adjustment then.