search

libretro / vice-libretro

Versatile Commodore 8-bit Emulator
GNU General Public License v2.0
40 stars 70 forks source link

VKBD enhancements #469

Closed sonninnos closed 2 years ago

sonninnos commented 2 years ago

VKBD:

C128:

Other:

Vweber73 commented 2 years ago

Got it, very nice, first time I see a proper C128 emulated keyboard, many thanks ! I see the Amiga core has changed version as well - any changes on the keyboard side as well ? Many thanks and best regards

Vweber73 commented 2 years ago

Maybe I misunderstood but I can't get how 40/80 columns works. The only working screen is the one I booted from, depending on the system options Vic/vdc setting. The other one is black screen, no matter how I play with the 40/80 key or Vic/Vdc setting. Am I missing something ?

sonninnos commented 2 years ago

But that is how it works. It depends on the software and the startup which is being actually outputted to, and there can be only one at a time.

Vweber73 commented 2 years ago

Thanks, but I still don't get it, sorry. I know that changing mode only takes effect once you reboot, and that only one is active at a time, but I get inconsistent results. When I press the 40/80 key, I can see the screen changing format. But when I restart sometimes it switches mode, sometimes it does not. I then chose the "soft" restart option, at first it switches mode, but doing it again keeps the same mode. I am confused on how to operate this...Does the 40/80 key overrides the system setting (VIC or VDC) ? Best regards

Le ven. 20 mai 2022 à 16:00, sonninnos @.***> a écrit :

But that is how it works. It depends on the software and the startup which is being actually outputted to, and there can be only one at a time.

— Reply to this email directly, view it on GitHub https://github.com/libretro/vice-libretro/pull/469#issuecomment-1132934481, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWBK3J35NLKRGMTWXPHDM4LVK6LHLANCNFSM5WNNY4SA . You are receiving this because you commented.Message ID: @.***>

sonninnos commented 2 years ago

Yes the core option is the initial startup state of that button, and the button overrides that. Maybe the VKBD key should be a similar toggle-key as ShiftLock is, since I found this explanation:

The 40/80 DISPLAY key is another mechanically latched button. It determines the display mode on power up or when the reset hutton is depressed. Latching it down defaults to the 80 column display. It has no effect once the computer is up and running.

So logically VICE uses the same key to switch the output (since 40/80 modes are physically via different outputs/monitors) even though it shouldn't actually do anything while running.

Vweber73 commented 2 years ago

Thanks, I understand now, the button is not (yet) a latch one, that's why I got results I felt were inconsistant, since I expected the "latch" behaviour. Yes indeed I think it should be the same as shift+lock :) Btw is there a dedicated reset button somewhere like on the real C128, or do I have to use RA "restart" (with the option of hard, soft, and other reset types) ? Also, in zoom mode, the status bar overrides the bottom part of the C128 screen, could it be below it ? Or RA constraints leaves no choice ? Best regards

sonninnos commented 2 years ago

The menu "Restart" does hardreset+autostart, as in it does not care about the core option. Core option reset type matters when using the hotkey (default End) or VKBD key.

And of course the statusbar has to be inside the screen. Use smaller zooming then if it is in the way.

Vweber73 commented 2 years ago

Ok, thanks. Is there a VKBD key for reset ? Could't find it... the one next to the tape deck doesn't seem to work...

So it is ok for your to make the 40/80 key a "latch" one in an upcoming version ?

Cheers

sonninnos commented 2 years ago

The VKBD reset key needs to be held down for a while, to prevent accidental touch screen presses.

And yes I'll look into it.

Vweber73 commented 2 years ago

Ah yes, I see it. Many thanks !

Vweber73 commented 2 years ago

Pressing the rectangle to hide the VKBD triggers "Monitor"... quite ennoying, just like for PUAE, Retroarch controls interferes with the emulated machine controls. PUAE and VICE are by far the best and most complete Commodore emulators for Android, but RetroArch constraints makes them more difficult to use than it should be. What is ok for game consoles is not adapted to computers. My dream would be to have these emulators nativelyw without those UI constraints, and especially with the possibility to have the (otherwise very good) VKBD below the emulated machine's screen, not over it with transparency. On my Samsung Z fold 3 this would be ideal use od the real estate...