libretro / vice-libretro

Versatile Commodore 8-bit Emulator
GNU General Public License v2.0
40 stars 70 forks source link

[Features Request] Update Vice to the latest version 3.8 #496

Closed KamiLordus closed 2 months ago

KamiLordus commented 1 year ago

Hi@sonninnos. I have a problem with the game Super Space Invaders (Domark). The game just doesn't work on Vice 3.7. I tested both the tap and g64 versions and the cpu jam error appears. Same problem on standalone vice 3.7. The bug was fixed after the release of Vice 3.7.1 (unfortunately I don't know which exactly version fixes this problem). In the tested version 3.7.1 r44453 (lates 3 days ago) the problem no longer occurs. Is it possible to switch to the latest version for vice core, or fix the bug in the current one? I'm posting both the tap version and the g64 version for testing if needed. Super Space Invaders.zip

sonninnos commented 1 year ago

Not really a huge fan of adding changes between versions, especially since 3.8 is around the corner again, but if you help finding the commit that fixes it, I can include it.

KamiLordus commented 1 year ago

Unfortunately, in the reviewed versions from the latest to 3.7 there is nothing about cpu_jam or space invaders. Alternatively, I will ask vice creators themselves, if they want to write back. I hope version 3.8 will appear soon :)

sonninnos commented 1 year ago

Well "soon" is a relative term, but they tend to do christmas releases, and I tend to swiftly update the core after that. So we might want a quicker solution.

KamiLordus commented 1 year ago

I wrote a question to them. But after security via sourceforge.net I don't think they answer questions often :) I'm also looking at closed and open bug reports on this page, but I don't see anything about it. Maybe it's called differently, or maybe it was fixed by the way.

edit: I'll let you know if I manage to find anything.

KamiLordus commented 1 year ago

They wrote back that SSI (vice version r44453) works fine. But I figured it out myself yesterday. So I started checking individual versions where the problem is and where not. And I quickly discovered that in the basic version of 3.7.1 the game does not work properly (CPU JAM at $D128). But already in the next update r44342 the game works without any problem. https://github.com/VICE-Team/svn-mirror/releases/tag/r44342

sonninnos commented 1 year ago

Hmm, r44342 can't surely be "next" from 3.7.1, since there is ~6 months of code between the dates.. and that particular commit does not look like being responsible.

KamiLordus commented 1 year ago

My mistake, I didn't notice that there is such a big gap between 3.7.1 and r44342. I don't see any earlier versions anywhere and probably the creators of vice themselves won't remember. It remains to wait for 3.8

KamiLordus commented 11 months ago

Hi sonninnos. Vice version 3.8 has just been released. Will it be possible to transfer it to the retroarch platform?

KamiLordus commented 5 months ago

Hi @sonninnos any chance for version 3.8? I'm currently checking out floppy disk games from the "preservation project" and how compatible they are with Vice. Unfortunately, there are some games that do not want to run under version 3.7 but work under 3.8. I would be grateful if you added the promised version 3.8 a long time ago :)

sonninnos commented 5 months ago

I can get to it only when I feel like it, and when I have less ongoing battles.

KamiLordus commented 5 months ago

Sorry to rush you and I know you have many projects (at least those related to Retroarch). For me, Vice (next to Puae) are the most important cores for Retroarch and I will fight for their support :) The Vice core is great and is superior to the stand alone versions, thanks to many useful features. Although I understand that it is not as popular as, for example, MAME.

sonninnos commented 2 months ago

It is happening!

retroarch_2024_09_11_18_44_03_950

KamiLordus commented 2 months ago

Another great news :) Thanks a lot @sonninnos.