search

libretro / virtualjaguar-libretro

Hard fork of Virtual Jaguar (abandoned project) to Libretro
31 stars 36 forks source link

[Android] core crashed after load content #14

Closed duskgao closed 1 year ago

duskgao commented 9 years ago

both nightly build & PlayStore build would crashed with the virtualjaguar core last half a month

andres-asm commented 9 years ago

confirmed, happens on Windows too and sadly the first broken commit is this one: https://github.com/libretro/virtualjaguar-libretro/commit/2ee290fcfb6a1e9f52d89efac4f46d4d020810da

Rayman was working fine before that

inactive123 commented 9 years ago

it still works fine on Linux, including that game.

andres-asm commented 9 years ago

It doesn't on Android and on windows...

On Sun, Sep 27, 2015, 6:42 AM Twinaphex notifications@github.com wrote:

it still works fine on Linux, including that game.

— Reply to this email directly or view it on GitHub https://github.com/libretro/virtualjaguar-libretro/issues/14#issuecomment-143544865 .

inactive123 commented 9 years ago

Guess we could start debugging it on Windows.

ghost commented 9 years ago

Crashes on Linux too. Nothing works.

Shoegzer commented 8 years ago

@Marc34: confirmed, also crashes using Linux Mint 17.2 x64, kernel 3.16.

I couldn't complete a git bisect, i got to this commit and couldn't even compile to test: f4071059bd2777e33f5b385530b5e0145e598413

I couldn't compile the commit posted above either (2ee290fcfb6a1e9f52d89efac4f46d4d020810da), but I can confirm that the commit immediately prior to that (ffec5c7) compiles fine and the core doesn't crash.

Hope it helps.

r-type commented 8 years ago

the convert (reference/ to pointer) done by this commit 2ee290fcfb6a1e9f52d89efac4f46d4d020810da forgot few point.

here is what i used to get core working again on my linux

http://pastebin.com/3LfVnVUP

inactive123 commented 8 years ago

Thanks for correcting my mistakes, I did a bad rush job at converting that code to C. I think I forgot to respect pointers to pointers here and there.

I pushed a commit of your diff patch and gave you credit, thanks.

Would you perhaps also be willing to look at 4DO? I think I might have made some mistake there too when converting the code from C++ to C. Would be grateful if you could go through it.

r-type commented 8 years ago

i m not C expert too , so maybe other mistake possible. i will look at 4DO.