search

libretro / vitaquake2

Quake II port for Libretro.
GNU General Public License v2.0
4 stars 16 forks source link

Menu is hard to close during demo playback #44

Closed DrUm78 closed 1 year ago

DrUm78 commented 1 year ago

Platforms: Tested on RetroArch Windows 11 and Libretro armv7 32-bit

Description: During a demo playback, it's very hard to close the menu with the cancel button, you have to release the key immediately after pressing it otherwise it will open the menu again. Please note that this issue does not happen while ingame but only during the demo.

Steps to reproduce:

  1. Launch the core (shareware or commercial version)
  2. During the demo loopback, press Start or the cancel menu key to open the menu
  3. Press the cancel menu key to close it
  4. Notice that it closes then opens immediately again
  5. Press the cancel menu key very quickly
  6. After a few tries, you should be able to close the menu
DrUm78 commented 1 year ago

Ok that's because all the keys open the menu during the attract mode so the cancel key (RETRO_DEVICE_ID_JOYPAD_B) is assigned to menu opening and closing at the same time, so it conflicts. I fixed it on my side by simply commenting this part (I prefer to keep only "Start" to open the menu anyway): https://github.com/DrUm78/vitaquake2/commit/f93a5dbfcb71d3423eb2c757e231b45a7d28410f but feel free to do it another way.