search

libsdl-org / SDL-1.2

Simple Directmedia Layer, 1.2 branch ... ***DEPRECATED***, please use https://github.com/libsdl-org/SDL for new projects!
https://libsdl.org
GNU Lesser General Public License v2.1
98 stars 81 forks source link

Use correct macros for Darwin PPC #871

Closed barracuda156 closed 1 year ago

barracuda156 commented 1 year ago

In few places wrong macros are used for Darwin PPC (it follows from code comments that MacOS is meant in those instances). There is no __powerpc__ on Darwin.

Three definitions are there: __ppc__ = ppc32 __ppc64__ = ppc64 __POWERPC__ = ppc32/ppc64

See, for example: https://opensource.apple.com/source/gcc/gcc-5465/gcc/config/rs6000/darwin.h.auto.html (Also, 10.6 does support ppc32.)

sezero commented 1 year ago

Are mac ppc builds before and after this patch tested at least on a 10.4? (testing also on 10.5 and 10.3 would be even better.)

barracuda156 commented 1 year ago

@sezero I have no 10.3, but 10.5 and 10.4 are doable.

For a note, my patch does not introduce any new code, it simply fixes macros in existing code so that they do apply when supposed to.

sezero commented 1 year ago

@sezero I have no 10.3, but 10.5 and 10.4 are doable.

Hearing results would be most appreciated

For a note, my patch does not introduce any new code, it simply fixes macros in existing code so that they do apply when supposed to.

Yes, and it now does build code for ppc, but it didn't used to before: hence the need for some testing.