search

libsdl-org / SDL-1.2

Simple Directmedia Layer, 1.2 branch ... ***DEPRECATED***, please use https://github.com/libsdl-org/SDL for new projects!
https://libsdl.org
GNU Lesser General Public License v2.1
98 stars 81 forks source link

x11: Fix SetGamma / Bypass SetGammaRamp when changing gamma #874

Closed hartwork closed 1 year ago

hartwork commented 1 year ago

Hi, happy new year!

This patch is in Gentoo Linux to this day and the patch author Petr Pisar confirmed and elaborated yesterday that the patch is still needed in 2023. What do you think?

Best, Sebastian

CC #717

ccawley2011 commented 1 year ago

Would it be possible to keep the SetGammaRamp path for video drivers that don't support SetGamma?

slouken commented 1 year ago

Yes, that seems like the right thing to do.

hartwork commented 1 year ago

I see. Your comment made me draft and share a new candidate for the next version of SetGamma with patch author Petr at https://bugs.gentoo.org/889412#c6 . If he considers it sane, I will make a new pull request, but maybe I missed or misunderstood something, let's see.

slouken commented 1 year ago

@hartwork, thank you. I will revert this change for now.

slouken commented 1 year ago

This is probably the fix you want: https://github.com/libsdl-org/SDL-1.2/commit/d4b1811edcbd2cc14b192c0dc7b4d5f25cc8864d

hartwork commented 1 year ago

@slouken interesting fix. Thanks for taking care!

slouken commented 1 year ago

You're welcome!