libsdl-org / SDL

Simple Directmedia Layer
https://libsdl.org
zlib License
9.98k stars 1.84k forks source link

[SDL3] C++ headers & modules #9771

Open CXCubeHD opened 6 months ago

CXCubeHD commented 6 months ago

Since SDL3 is in development, I would like to propose that there should be some kind of C++ header generation. This would make using headers way more comfortable as a C++ user. I really like the way VulkanHpp was implemented.

On top of that SDL3 should have optional (by default off) C++ 20 Module support (just like VulkanHpp aswell). Much work has been done on the compiler and CMake side to make this as easy as possible (read this article for more).

I would really love to see this happen

Edit:

For good C++ adaptation I would expect the following:

  1. Namespacing:

Example:

sdl::Delay(2000); // sdl namespace is lowercase, types & functions are PascalCase
sdl::Event e;
  1. Flags as enum class:

(some flags will have to be renamed because of clarity)

Example:

SDL_SOMEFLAG_FLAG1
sdl::SomeFlag::Flag1

SDL_SOMEFLAG_FLAG1 | SDL_SOMEFLAG_FLAG2

sdl::SomeFlag::Flag1 | sdl::SomeFlag::Flag2
Sackzement commented 6 months ago

Please no lower-case sdl, this looks so wrong. :)

CXCubeHD commented 6 months ago

Please no lower-case sdl, this looks so wrong. :)

I guess uppercase SDL would also be okay then. It could even be made configurable through a macro and cmake (just like VulkanHpp)

slouken commented 6 months ago

Feel free to submit a PR for this.

CXCubeHD commented 6 months ago

Feel free to submit a PR for this.

Yo I feel like I can do this but I need to get more familiar with the code / project structure 👌

TerensTare commented 5 months ago

I'm pretty sure this can easily be solved by writing a parser that goes through all the file and generates an intermediate representation in json, which is then converted into a C++ module file. The parser can hugely simplify the process of generating bindings to other languages. This is the approach taken by both ImGui (see here ) and Raylib (see here ) to generate some kind of "API dump" in JSON/other format, which is then translated into the target language code.

Finally, since by adopting this parser the target becomes larger than C++ bindings, I think it should be part of a separate repo that is only used by maintainers of bindings in other languages.

madebr commented 5 months ago

@TerensTare See https://github.com/libsdl-org/SDL/issues/6337 If you know how to write such a parser, that would enable lots of other things.

TerensTare commented 5 months ago

I will try to write a set up a parser with minimal features that can be easily improved and come back with a PR.

TerensTare commented 4 months ago

So here's my attempt at this: it's not final but covers both namespacing and strong typed enums. You simply need Python>=3.10 to codegen the C++ modules and the resulting code can be used like this.