Closed traversaro closed 6 months ago
Sorry for the noise, there was a typo in the CMake, not it should be fixed.
Looks good to me, and possibly needed in all active branches. @madebr ?
Looks great. Too bad upstream didn't go with an ALIAS library, but that could probably break backwards compatibility.
Is this needed in SDL3 and/or release-2.8.x ?
Oh yes, all branches.
Leaving to your care ;)
Done. I had to fix SDL2 slightly in b9694685952ac6cc287c9e30c03305860496baf6
SDL3: 25e816f614dbe4aa9fdaf89c248ae283f20038f9 2.8.x: 02c81284c92e2097a6559a46e188f27f2039e2fd
When using CMake >= 3.28, the build on Windows can fail with the following error:
The error is due to https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8803, that changed
TIFF::TIFF
to be an interface library that just acts as a sort of alias toTIFF::tiff
. This PR fixes this problem by usingTIFF::tiff
if it is defined, and just useTIFF::TIFF
ifTIFF::tiff
is not defined.