search

libsdl-org / SDL_image

Image decoding for many popular formats for Simple Directmedia Layer.
zlib License
559 stars 182 forks source link

cmake: use MACHO* properties to set macho version #442

Closed madebr closed 5 months ago

madebr commented 6 months ago

See https://github.com/libsdl-org/SDL_ttf/pull/349

madebr commented 6 months ago

I have no idea why the Macos autotools tests fail, but the CMake ones do not.

madebr commented 6 months ago

I have no idea why the Macos autotools tests fail, but the CMake ones do not.

Autotools uses system (homebrew) dependencies, CMake uses vendored dependencies. So the homebrew libraries have higher "inaccuracy".

slouken commented 6 months ago

Yeah, we should probably disable ImageIO for the autotools CI. I'm assuming that's what's causing the issue?

madebr commented 6 months ago

Yeah, we should probably disable ImageIO for the autotools CI. I'm assuming that's what's causing the issue?

No, it's only libjxl that's causing issues. Porting this patch to SDL3_image, I get the same error.