the Xcode project needs updating

libsdl-org / SDL_mixer

An audio mixer that supports various file formats for Simple Directmedia Layer.

zlib License

432 stars 147 forks source link

the Xcode project needs updating #565

Closed sezero closed 10 months ago

sezero commented 1 year ago

Xcode project needs updating for both SDL2 and SDL3 branches:

wavpack option should be enabled: MUSIC_WAVPACK must be defined
A wavpack project must be created, like the others, and must be integrated in the main SDL_mixer project (like the others..)

A job for @slouken (can't do myself.)

sezero commented 10 months ago

@slouken: wavpack.framework seems to be missing in prerelease 2.7.2 dmg

slouken commented 10 months ago

Fixed for release, thanks!

sezero commented 10 months ago

I minorly updated our vendored libgme (game-music-emu): the submodule should point to commit cdd021507518162a4884898bbac85cbd32ed7a77 -- please make sure your copies are updated.

slouken commented 10 months ago

Please don't do that when we have a release candidate pending unless it's a critical fix. If it's not necessary for release, can you please revert until next week?

sezero commented 10 months ago

Please don't do that when we have a release candidate pending unless it's a critical fix. If it's not necessary for release, can you please revert until next week?

It is a build fix: https://github.com/libsdl-org/game-music-emu/commit/cdd021507518162a4884898bbac85cbd32ed7a77 If you're sure, yes I can easily revert

slouken commented 10 months ago

Okay, that looks fine, but in general once a pre-release tag is added to a project, that code is frozen except for critical bug fixes until release. We don't want to introduce any regressions between the time the public tries out the release candidate and the final release.