search

libsdl-org / SDL_mixer

An audio mixer that supports various file formats for Simple Directmedia Layer.
zlib License
431 stars 147 forks source link

Fix libxmp-lite pkgconf #575

Closed sharkwouter closed 11 months ago

sharkwouter commented 12 months ago

Without this change I get the following error when using pkg-config after building with libxmp-lite:

Package libxmplite was not found in the pkg-config search path.
Perhaps you should add the directory containing `libxmplite.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libxmplite', required by 'SDL2_mixer', not found

This is mostly relevant for Playstation Portable and Vita builds, but there are probably other platforms which want support for the formats libxmp-lite offers. Especially since is has an easier to work with license than libxmp.

sezero commented 12 months ago

PC_REQUIRES part looks correct tome. For the other first part, I'll defer to @madebr

madebr commented 11 months ago

main needs the same fix. Feel free to open a PR, or I'll do it once I get back to my PC. https://github.com/libsdl-org/SDL_mixer/blob/76720e6ea298f937548e54f75083133bf4c86f1b/CMakeLists.txt#L821

madebr commented 11 months ago

Applied to SDL3_mixer in 1d30b089adf8eedeb0559421619171a610948216