search

libsdl-org / SDL_mixer

An audio mixer that supports various file formats for Simple Directmedia Layer.
zlib License
430 stars 147 forks source link

VisualC: correct OGG_DYNAMIC #639

Closed madebr closed 1 month ago

madebr commented 1 month ago

https://github.com/libsdl-org/SDL_mixer/blob/e32ba24f21208c7a20328dbb5111a237495514c8/VisualC/SDL_mixer.vcxproj#L114 Is this correct? Shouldn't it be `OGG_DYNAMIC="libogg-0.dll"?

Please don't fix this in git, I'll fix this when I "dump" the release scripts ;)

sezero commented 1 month ago

https://github.com/libsdl-org/SDL_mixer/blob/e32ba24f21208c7a20328dbb5111a237495514c8/VisualC/SDL_mixer.vcxproj#L114

Is this correct?

Yes

Shouldn't it be `OGG_DYNAMIC="libogg-0.dll"?

No. (We import from libvorbisfile which happens to piggy-back to libvorbis which in turn makes use of libogg.)

sezero commented 1 month ago

P.S.: It's just that OGG_DYNAMIC name is just misleading, that's all.

madebr commented 1 month ago

Thanks! I see CMake is also doing what you described.

gvanem commented 1 month ago

Speaking of OGG. I have an issue that I'd like some to explain to me.

I built the playmus.exe example on Win-10 and tried to play a .ogg file. It works fine with this. But I fail to understand why the specified -DOGG_DYNAMIC=\"ogg.dll\" is not loaded into the playmus.exe process.

E.g. this debug command does not list ogg.dll:

 cdb -c g playmus.exe mamma-mia.ogg | grep -i ogg

How come?

madebr commented 1 month ago

When defining OGG_USE_STB, it will use stb_vorbis to load ogg files.