libsdl-org / sdl12-compat

An SDL-1.2 compatibility layer that uses SDL 2.0 behind the scenes.
Other
197 stars 40 forks source link

Gravity Wars: messed up colour palette #238

Closed smcv closed 2 years ago

smcv commented 2 years ago

Prerequisites:

To reproduce:

Expected result: all work, except for their access to high scores not working because this use of ld.so disables setgid

Actual result: a segfault with Wayland ­— this was caused by setgid games, similar to https://github.com/libsdl-org/sdl12-compat/issues/247#issuecomment-1276887769

Actual result: with sdl12-compat, either native Wayland or X11, the colour palette is wrong. Classic SDL 1.2:

gravitywars-good

sdl12-compat:

gravitywars-bad

icculus commented 2 years ago

Same deal about LD_LIBRARY_PATH and setgid binaries, but the colors are wrong on this game once you get past that.

icculus commented 2 years ago

(if you remove the setgid bit, it'll fail to write the highscore and terminate the process at the end of the first round, but that's not an sdl12-compat issue.)

icculus commented 2 years ago

Also broken by 9da8808c03e80a228ee66a714091249f331ebcd7.

smcv commented 2 years ago

Confirmed fixed as of https://github.com/libsdl-org/sdl12-compat/commit/67f8b3a85b782eefb4db90f34d5b0742ef2cb5fc (1.2.58 + 29 commits)