libsdl-org / sdl12-compat

An SDL-1.2 compatibility layer that uses SDL 2.0 behind the scenes.
Other
193 stars 40 forks source link

openjazz: Renders in monochrome #248

Closed smcv closed 1 year ago

smcv commented 1 year ago

Prerequisites:

To reproduce:

Expected result: all work

Actual result: real SDL 1.2 works as expected, sdl12-compat renders in monochrome similar to #246

icculus commented 1 year ago

This broke with 9da8808c03e80a228ee66a714091249f331ebcd7, so clearly my understanding of SDL 1.2 palette management is not correct. I'll look into this further.

sezero commented 1 year ago

This one should be fixed by 35488c6 ?

Also: Did 35488c6 not bring back #216?

icculus commented 1 year ago

Also: Did https://github.com/libsdl-org/sdl12-compat/commit/35488c6894cb55ae4019392022c418f54dc3eb42 not bring back https://github.com/libsdl-org/sdl12-compat/issues/216?

It did, I just hadn't reopened it yet. :)

smcv commented 1 year ago

Confirmed fixed as of https://github.com/libsdl-org/sdl12-compat/commit/67f8b3a85b782eefb4db90f34d5b0742ef2cb5fc (1.2.58 + 29 commits)