search

libsdl-org / sdl2-compat

An SDL2 compatibility layer that uses SDL3 behind the scenes.
zlib License
80 stars 19 forks source link

Updated for SDL3 change to use SDL_bool instead of int return code #210

Closed slouken closed 2 months ago

sezero commented 2 months ago

Looks OK, as far as I can see.

sezero commented 2 months ago

Off-topic: It maybe early yet, but the version requirement in sdl2-compat is broken as it is: we require sdl >=3.0.0, but we will be requiring >= 3.2.0 when sdl3 is frozen. (Even sdl3 headers' since fields are incorrect, because they spell 3.0.0...) With sdl3 still a fast moving target, can't we do something about that? I.e. Always increase the micro version of sdl3 whenever an api/abi change occurs and update sdl2-compat accordingly?

slouken commented 2 months ago

Off-topic: It maybe early yet, but the version requirement in sdl2-compat is broken as it is: we require sdl >=3.0.0, but we will be requiring >= 3.2.0 when sdl3 is frozen. (Even sdl3 headers' since fields are incorrect, because they spell 3.0.0...) With sdl3 still a fast moving target, can't we do something about that? I.e. Always increase the micro version of sdl3 whenever an api/abi change occurs and update sdl2-compat accordingly?

Right now we require the latest version of SDL3. Once we have a frozen ABI, we'll set it to that version and any future API changes in SDL will generate a version bump that we can match as needed.

sezero commented 2 months ago

Right now we require the latest version of SDL3.

Yes, but sdl2-compat doesn't know that. Take yesterday's sdl2-compat build and run against today's sdl3 with bool changes (or vice versa), and see your pc explode.

slouken commented 2 months ago

Right now we require the latest version of SDL3.

Yes, but sdl2-compat doesn't know that. Take yesterday's sdl2-compat build and run against today's sdl3 with bool changes (or vice versa), and see your pc explode.

Don't do that. :) Seriously, main code in projects depend on main code in other projects. Once we have a release, we'll have proper dependencies and versioning.

sezero commented 2 months ago

OK then :))