Closed Semphriss closed 3 months ago
This looks good. I'm adding this and then fixing the syntax error.
Okay, make sure I didn't screw this up in 3a5ce94d54dba2268d86c2257fd73d9b2ec1b366.
(Outside of this specific example: should this callback send in the filter array too, so we don't have to have a global to figure out what the filter
argument is referring to? Let me know if I should open an issue about it.)
I reviewed the commit and everything looked fine.
One thing though, there are still \n
's with SDL_Log in test/testdialog.c
, should they be removed too?
SDL_Log messages should be terminated with "\n"
Replaces https://github.com/libsdl-org/SDL/pull/9729, the same description applies.
This is my first PR here, please let me know if I got something wrong!