search

libsdl-org / sdlwiki

This is the raw contents of SDL's wiki. You can edit this through GitHub or at https://wiki.libsdl.org/ now!
https://wiki.libsdl.org/
79 stars 32 forks source link

Chore: add removal script to ci #550

Closed Green-Sky closed 2 months ago

Green-Sky commented 2 months ago

The auto removal script from https://github.com/libsdl-org/sdlwiki/pull/497 should be added to ci, and should be run weekly.

SDL_GetRendererInfo and SDL_RendererInfo where removed recently, maybe there is more...

Green-Sky commented 2 months ago

How? If the script generates a difference, it should create (or update) a pr automatically.

icculus commented 2 months ago

So I don't want to add this to CI, since once SDL3 is locked down, we should never remove a symbol (until SDL4, at least).

Also, the script will only catch symbols that have been renamed from SDL2; it won't catch things that were completely removed, and it won't catch symbols we added and then changed/removed during SDL3 development.

Case in point: It didn't catch SDL_GetRendererInfo when I just tried it.

Green-Sky commented 2 months ago

Right, good points.