search

libsdl-org / sdlwiki

This is the raw contents of SDL's wiki. You can edit this through GitHub or at https://wiki.libsdl.org/ now!
https://wiki.libsdl.org/
83 stars 37 forks source link

Background may be too dark #6

Closed Erquint closed 3 years ago

Erquint commented 3 years ago

I prefer dark to bright but this is uncomfortably dark. This depends a lot on people's display capabilities, such as the capacity for contrast and, of course, personal preference. Options would be very welcome but you could go for a dim compromise rather than what would look to some, myself sadly included, as pitch-black void.

icculus commented 3 years ago

I agree, I'm going to lighten it slightly.

(the CSS actually makes the page goes dark when the browser reports itself in dark mode, fwiw, but tweaking this is still ongoing.)

icculus commented 3 years ago

Current: 2021-03-30_18-39

Proposed: 2021-03-30_18-42

The proposed version matches the text/background colors for GitHub's new "dark dimmed" theme. Is that better?

Erquint commented 3 years ago

Much better indeed. I was going to suggest taking a page from GH's theme.

Erquint commented 3 years ago

As for adapting to browser/OS color — I don't think those features are developed/integrated/supported enough yet to rely on.

icculus commented 3 years ago

As for adapting to browser/OS color — I don't think those features are developed/integrated/supported enough yet to rely on.

They aren't; mostly it's only reliable on macOS and iOS at the moment, but the CSS defaults to light mode on things that don't understand the CSS magic.

We could add an option to select a mode in the UI, but that's low priority for me atm.

icculus commented 3 years ago

Fixed in https://github.com/icculus/ghwikipp/commit/35c7f5cc6a02b659231f4de75e91352f8f86d717

Erquint commented 3 years ago

Technically, I see this feature supported on both Windows and Android as well but I can also see how some discrepancies may arise, especially depending on user software choices.