search

libsemigroups / libsemigroups_pybind11

Python bindings for the libsemigroups C++ library for semigroups and monoids
https://libsemigroups.github.io/libsemigroups_pybind11
GNU General Public License v3.0
6 stars 7 forks source link

Update tests for monoid output for orientation preserving and reversing monoids #108

Open MTWhyte opened 1 year ago

MTWhyte commented 1 year ago

This PR updates the tests for orientation_preserving_monoid and orientation_reversing_monoid to work with monoid presentation output, rather than semigroup presentation.

MTWhyte commented 1 year ago

The CI tanked, but we expected this, right?

james-d-mitchell commented 1 year ago

Thanks @MTWhyte, yes I think I'd expect the CI to tank. Perhaps the test can be made more robust using something similar to:

https://github.com/libsemigroups/libsemigroups_pybind11/blob/ef498fb7fa77555846d86c2dfb61734b9adc48c5/tests/test_present.py#L631-L641

This way we can merge and everything will be ok!

MTWhyte commented 1 year ago

Thanks @MTWhyte, yes I think I'd expect the CI to tank. Perhaps the test can be made more robust using something similar to:

https://github.com/libsemigroups/libsemigroups_pybind11/blob/ef498fb7fa77555846d86c2dfb61734b9adc48c5/tests/test_present.py#L631-L641

This way we can merge and everything will be ok!

I think we touched on this the other day, I understand presentation.make gives a string presentation, whereas fpsemigroup.make gives a word-type presentation. Just to check: since I'm using the latter here, should this test be independent of the version? Or am I mistaken and in fact make from both namespaces will use strings?