Add `SchreierSims` for v1

libsemigroups / libsemigroups_pybind11

Python bindings for the libsemigroups C++ library for semigroups and monoids

https://libsemigroups.github.io/libsemigroups_pybind11

GNU General Public License v3.0

6 stars 7 forks source link

Add `SchreierSims` for v1 #200

Closed Joseph-Edwards closed 5 days ago

Joseph-Edwards commented 2 weeks ago

This PR adds the SchreierSims class and associated helpers in advance of the v1 release. Supersedes #109.

TODO

[x] Add the bindings to the cpp file;
[x] Expose the functionality in libsemigoups_pybind11;
[x] Add the the pages to the doc;
[x] Wrap the class in a Python class (after #197 is merged);
[x] Format the documentation and the signatures;
[x] Add tests.

Joseph-Edwards commented 5 days ago

The macOS tests are failing because SchreierSims and FroidurePin have identical constructors. @james-d-mitchell, do you think we should edit these classes to inherit from a common InitFromGenerators abstract base class, or just suppress the warning?

james-d-mitchell commented 5 days ago

The macOS tests are failing because SchreierSims and FroidurePin have identical constructors. @james-d-mitchell, do you think we should edit these classes to inherit from a common InitFromGenerators abstract base class, or just suppress the warning?

Maybe simplest to just add a TODO to do that later and to disable the linting error for now