search

libsidplayfp / sidplayfp

Console SID/MUS player
GNU General Public License v2.0
37 stars 7 forks source link

fix note displaying #30

Closed ruby-R53 closed 8 months ago

ruby-R53 commented 8 months ago

on line 547 of menu.cpp, ANDing registers[0x01 + i * 0x07] with $F caused some notes to be displayed incorrectly, some of them were off by a few semitones, while others by even some octaves

masking that register wasn't making much sense to me, so i got curious and removed that just to see what would happen

drfiemost commented 8 months ago

Thanks for the fix, next time please use a more descriptive commit message.

ruby-R53 commented 8 months ago

no problem, this was my first time making a pull request so i didn't really know how to write a message for it lol