Note detection off by a semitone when forcing PAL/NTSC signal via command line

libsidplayfp / sidplayfp

Console SID/MUS player

GNU General Public License v2.0

34 stars 8 forks source link

Note detection off by a semitone when forcing PAL/NTSC signal via command line #37

Closed ruby-R53 closed 3 days ago

ruby-R53 commented 6 days ago

When using either -vnf or -vpf, sidplayfp still uses the frequency table specified by the tune to display the notes, and that makes the note display off by one semitone.

I tried fixing it by editing args.cpp and repointing m_freqTable to freqTablePal/freqTableNtsc when -vpf/-vnf is used but I couldn't.

I'm using sidplayfp's latest release.

drfiemost commented 3 days ago

Should be fixed in master, can you please check?

ruby-R53 commented 3 days ago

it's working!