search

libsidplayfp / sidplayfp

Console SID/MUS player
GNU General Public License v2.0
38 stars 8 forks source link

Adding Kernal ROM results in glitches in the samples in MUSICIANS\E\Encore\Spread_Eagle_Idaho.sid #55

Open acrouzet opened 1 month ago

acrouzet commented 1 month ago

I'm using the V3 Kernal. Taking the Kernal ROM out of sidplayfp's search paths fixes the glitches. I'm unsure if this is a problem with the Kernal itself, or if its an emulation issue, or something else.

ruby-R53 commented 1 month ago

i can reproduce it, so probably not the former

i'd guess it's an emulation issue because that's a similar case to #39, where removing the kernal rom fixed the issue as well (although it had more to do with audio buffer stuff, still related tho')

drfiemost commented 1 month ago

More likely a bad rip. Did you try with other players, possibly vsid?

acrouzet commented 1 month ago

It works in jsidplay2.

drfiemost commented 1 month ago

What kind of glitches? I can't hear anything wrong here.

ruby-R53 commented 1 month ago

i can't either anymore, i tried playing it using the reSID engine once and it sounded fine there, then i went back to reSIDfp and it somehow played normally too

what i heard when i was able to reproduce however seemed to be the samples being played way louder than how they were supposed to

EDIT: i can reproduce it again now, for some reason just removing RESID from Engine in the configuration file wasn't enough, i had to run it with --residfp too

acrouzet commented 1 month ago

Yeah, I can't recreate it anymore either. Strange.

drfiemost commented 1 month ago

So it's a random behaviour... is this on Windows? Please add some details if you can reproduce this consistently in the future, it may be some uninitialized var or something.

acrouzet commented 1 month ago

Yes this is on Windows.