search

libsndfile / libsamplerate

An audio Sample Rate Conversion library
http://libsndfile.github.io/libsamplerate/
BSD 2-Clause "Simplified" License
616 stars 169 forks source link

add options for conversion quality management #127

Closed jerpelea closed 3 years ago

jerpelea commented 3 years ago

Many NuttX boards have limited resources and will have to use compile time quality options to reduce resource usage

Signed-off-by: Alin Jerpelea alin.jerpelea@sony.com

jerpelea commented 3 years ago

@evpobr local make && make test does not fail

evpobr commented 3 years ago

Look at #128.

jerpelea commented 3 years ago

@evpobr I can add the options for the build system for other OSes. In our case they are set in Kconfig for NuttX OS

evpobr commented 3 years ago

First we need to add ifdefs to libsamplerate's code and its buildsystems. I've started work in #128 but i have no time to complete it, i'll probably be very busy for the rest of the year. You can try if you wish.

jerpelea commented 3 years ago

@evpobr it is already done. please check my patch

jerpelea commented 3 years ago

@evpobr local build and test was ok. I will fix the CI ones

jerpelea commented 3 years ago

@evpobr no more errors. please review

jerpelea commented 3 years ago

where should those options be located for autotools?

evpobr commented 3 years ago

This could help: https://autotools.io/autoconf/arguments.html.

jerpelea commented 3 years ago

@evpobr done. It seems to work. Please review

jerpelea commented 3 years ago

@evpobr done

evpobr commented 3 years ago

Thanks @jerpelea!