search

libsndfile / libsamplerate

An audio Sample Rate Conversion library
http://libsndfile.github.io/libsamplerate/
BSD 2-Clause "Simplified" License
600 stars 167 forks source link

Implement SSE2 lrint() and lrintf() #188

Closed rfomin closed 1 year ago

rfomin commented 1 year ago

Fix #187

erikd commented 1 year ago

The used to have CI on this project. I think Travis (the old CI) has disappeared, but it should be possible to do something with Github Actions (even if its just Linux, which should be the easiest).

rfomin commented 1 year ago

The used to have CI on this project.

It looks like CI is here: https://github.com/libsndfile/libsamplerate/blob/master/.github/workflows/build.yml Someone just needs to approve running workflow, I'm first time contributor.

evpobr commented 1 year ago

Errors are unrelated to PR. We need to update CI.

evpobr commented 1 year ago

Thanks @rfomin !

sezero commented 1 year ago

The patch here might be OK for x86_64, but it doesn't give us disabling SSE2 code for x86 builds: I suggest some configury switch like --enable-sse2 (and an equivalent of it in cmake.)