Closed sezero closed 1 year ago
LGTM
Do we really need to limit SSE2 to x64?
Do we really need to limit SSE2 to x64?
No, we don't. But can you guarantee that __SSE2__
is defined on x86?
Do we really need to limit SSE2 to x64?
No, we don't. But can you guarantee that
__SSE2__
is defined on x86?
E.g.: see the build error I noted in #191
Any verdict ?
Any verdict ?
Not sure redefining lrintf is good idea.
Not sure redefining lrintf is good idea.
I don't see the harm since we're doing it privately - but if you want static inlines, tell me.
Anyways, I force-pushed a version that keeps the inlines as inlines - no redefines.
Thanks @sezero !
Fixes https://github.com/libsndfile/libsamplerate/issues/187 Fixes https://github.com/libsndfile/libsamplerate/pull/188 Fixes https://github.com/libsndfile/libsamplerate/issues/191
CC: @rfomin