libsndfile / libsamplerate

An audio Sample Rate Conversion library
http://libsndfile.github.io/libsamplerate/
BSD 2-Clause "Simplified" License
600 stars 167 forks source link

(minor) Warnings for lrint when compiling in Xcode for iOS #212

Open KoenT-SS opened 4 months ago

KoenT-SS commented 4 months ago

First: thanks to Erik and everyone else here for making and maintaining libsamplerate!

This is just a minor issue (I think):

I'm seeing several warnings in Xcode when compiling for iOS arm64 in Xcode (15.3):

Compiling src_sinc.c
/Users/.....snip...../libsamplerate/src/common.h:221:9: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        return lrintf (x) ;
/Users/.....snip...../libsamplerate/src/common.h:226:9: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        return lrint (x) ;

Compiling src_zoh.c
/Users/.....snip...../libsamplerate/src/common.h:221:9: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        return lrintf (x) ;
/Users/.....snip...../libsamplerate/src/common.h:226:9: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        return lrint (x) ;

Compiling samplerate.c
/Users/.....snip...../libsamplerate/src/common.h:221:9: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        return lrintf (x) ;
/Users/.....snip...../libsamplerate/src/common.h:226:9: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        return lrint (x) ;

Compiling src_linear.c
/Users/.....snip...../libsamplerate/src/common.h:221:9: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        return lrintf (x) ;
/Users/.....snip...../libsamplerate/src/common.h:226:9: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
        return lrint (x) ;

I'm building after generating Xcode build files (including the config.h file) using cmake like this:

cmake .. -GXcode -DCMAKE_SYSTEM_NAME=iOS

I'm attaching the config.h file here for completeness sake. Since I couldn't attach a .h file, I had to rename it to config.h.txt. config.h.txt

I think the warnings can probably be safely ignored in this case, but it's a bit annoying to see them each time for an otherwise flawless build. So, if there is an easy fix, that might clean it up.

evpobr commented 4 months ago

Hi @KoenT-SS