search

libsql / sqlalchemy-libsql

SQLAchemy dialect for libSQL
MIT License
20 stars 7 forks source link

Test suite fails with `sqlite3` module #4

Open penberg opened 1 year ago

penberg commented 1 year ago

If I switch the dialect to use sqlite3 module under the hood, not all tests pass:

========================================================================================= short test summary info ==========================================================================================
SKIPPED [1] .env/lib/python3.11/site-packages/sqlalchemy/testing/config.py:385: 'test/test_suite.py::DialectTest_sqlite+libsql_3_42_0::test_pysqlcipher_connects (call)' : not sqlite+pysqlcipher
SKIPPED [2] .env/lib/python3.11/site-packages/sqlalchemy/testing/config.py:385: 'test.test_suite.SavepointTest' unsupported on any DB implementation 'sqlite(3.42.0)+libsql'marked as skip
================================================================================ 177 passed, 3 skipped, 10 errors in 0.33s =================================================================================
barbieri commented 1 year ago

@penberg are any tests failing? Or you jus mean these 2 skips? The skips are expected since we don't support savepoint neither we're pysqlcipher