search

libsql / sqld

LibSQL with extended capabilities like HTTP protocol, replication, and more.
https://libsql.org
903 stars 38 forks source link

fix bad naming for namespace header key #656

Closed MarinPostma closed 1 year ago

MarinPostma commented 1 year ago

Tonic panics if the key for a binary header is not formatted correctly. Tonic doc could be clearer as to what is not a proper formatting, so I had to ding into tonic source to figure it out. And it turns out keys for binary metadata must be suffixed with -bin. Now we know :smile:

MarinPostma commented 1 year ago

self-merging so we can move on, but FYI @LucioFranco