libsql / sqld

LibSQL with extended capabilities like HTTP protocol, replication, and more.
https://libsql.org
903 stars 38 forks source link

Configure AWS SDK Automatically #762

Open mustafaakin opened 1 year ago

mustafaakin commented 1 year ago

Looking at bottomless project readme and source code, it looks like it always expects AWS Access Key and Secret Key from ENV variables. https://github.com/libsql/sqld/blob/146df902f81a65adc4943112d1a9f0a9ecd9c881/bottomless/src/replicator.rs#L140

However, in AWS computing, the SDKs should be able to auto-configure it from the multiple credential providers, so it works seamlessly in EC2, Fargate or EKS with IAM Roles. Instead of specifying the prefixing related env variables with bottomless IAM access keys through env variables, I think we should rely on Rust SDK so the proper chain can be used automatically. Currently it fails with:

$ sqld --enable-bottomless-replication
..
    LIBSQL_BOTTOMLESS_AWS_DEFAULT_REGION was not set