search

libsv / go-bt

The go-to Bitcoin Transaction (BT) Go library.
https://pkg.go.dev/mod/github.com/libsv/go-bt
ISC License
67 stars 26 forks source link

Update MinPushSize to use uint #126

Closed shruggr closed 1 year ago

shruggr commented 2 years ago

Building for 32bit in TinyGo for a web-assembly build, comparing an int to 0xffffffff leads to the following build error:

github.com/libsv/go-bt/v2@v2.1.0-beta.4/bscript/script.go:412:9: 0xffffffff (untyped int constant 4294967295) overflows int

I have updated both the function and the test to use uint, which solves the problem

mergify[bot] commented 1 year ago

This pull request looks stale. Feel free to reopen it if you think it's a mistake.

mergify[bot] commented 1 year ago

:warning: The sha of the head commit of this PR conflicts with #129. Mergify cannot evaluate rules on this PR. :warning:

mergify[bot] commented 1 year ago

:warning: The sha of the head commit of this PR conflicts with #129. Mergify cannot evaluate rules on this PR. :warning: