libsv / go-bt

The go-to Bitcoin Transaction (BT) Go library.
https://pkg.go.dev/mod/github.com/libsv/go-bt
ISC License
67 stars 26 forks source link

Update MinPushSize to use uint #129

Closed shruggr closed 1 year ago

shruggr commented 1 year ago

@jadwahab Previous PR was marked as stale.

Resubmitting

codecov-commenter commented 1 year ago

Codecov Report

Base: 83.86% // Head: 83.86% // No change to project coverage :thumbsup:

Coverage data is based on head (17c99f8) compared to base (34e82d8). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 17c99f8 differs from pull request most recent head cbcf5b0. Consider uploading reports for the commit cbcf5b0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #129 +/- ## ======================================= Coverage 83.86% 83.86% ======================================= Files 34 34 Lines 3670 3670 ======================================= Hits 3078 3078 Misses 426 426 Partials 166 166 ``` | [Impacted Files](https://codecov.io/gh/libsv/go-bt/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv) | Coverage Δ | | |---|---|---| | [bscript/script.go](https://codecov.io/gh/libsv/go-bt/pull/129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-YnNjcmlwdC9zY3JpcHQuZ28=) | `63.22% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

theflyingcodr commented 1 year ago

@shruggr can you pull latest master to resolve the linter issues.

mergify[bot] commented 1 year ago

This pull request looks stale. Feel free to reopen it if you think it's a mistake.