jadwahab
commented
1 year ago Note sure if we should split out the ordinals files into a separate directory/module or keep them in the main bt module package. We could even potentially make the receiver functions on bt.Tx but I think it's better to keep it a separate function that takes the tx in the Args struct.
Leaning towards separating out, but if anyone has any better ideas please let me know.
Codecov Report
Patch coverage:
43.40% and project coverage change:-2.91:warning::mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #142 +/- ## ========================================== - Coverage 83.70% 80.80% -2.91% ========================================== Files 34 37 +3 Lines 3701 3985 +284 ========================================== + Hits 3098 3220 +122 - Misses 434 546 +112 - Partials 169 219 +50 ``` | [Impacted Files](https://codecov.io/gh/libsv/go-bt/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv) | Coverage Δ | | |---|---|---| | [output.go](https://codecov.io/gh/libsv/go-bt/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-b3V0cHV0Lmdv) | `86.95% <ø> (ø)` | | | [utxo.go](https://codecov.io/gh/libsv/go-bt/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-dXR4by5nbw==) | `75.00% <ø> (ø)` | | | [inscriptions.go](https://codecov.io/gh/libsv/go-bt/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-aW5zY3JpcHRpb25zLmdv) | `28.00% <28.00%> (ø)` | | | [tx.go](https://codecov.io/gh/libsv/go-bt/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-dHguZ28=) | `76.07% <28.57%> (-1.22%)` | :arrow_down: | | [unlocker/simple.go](https://codecov.io/gh/libsv/go-bt/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-dW5sb2NrZXIvc2ltcGxlLmdv) | `59.09% <33.33%> (-5.91%)` | :arrow_down: | | [bscript/script.go](https://codecov.io/gh/libsv/go-bt/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-YnNjcmlwdC9zY3JpcHQuZ28=) | `59.59% <37.70%> (-5.66%)` | :arrow_down: | | [ord/bidding.go](https://codecov.io/gh/libsv/go-bt/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-b3JkL2JpZGRpbmcuZ28=) | `50.00% <50.00%> (ø)` | | | [ord/listing.go](https://codecov.io/gh/libsv/go-bt/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-b3JkL2xpc3RpbmcuZ28=) | `52.23% <52.23%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.