libsv / go-bt

The go-to Bitcoin Transaction (BT) Go library.
https://pkg.go.dev/mod/github.com/libsv/go-bt
ISC License
66 stars 26 forks source link

refactor!: change bids and lists to use 1 dummy instead of 2 #149

Closed jadwahab closed 1 year ago

jadwahab commented 1 year ago

Move out 2 dummy code into separate file. Not sure whether to keep or just remove. Kept for now.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 60.47% and project coverage change: -0.19 :warning:

Comparison is base (da68c79) 80.80% compared to head (c85e49c) 80.61%.

:exclamation: Current head c85e49c differs from pull request most recent head 07f43a3. Consider uploading reports for the commit 07f43a3 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #149 +/- ## ========================================== - Coverage 80.80% 80.61% -0.19% ========================================== Files 37 38 +1 Lines 3985 4112 +127 ========================================== + Hits 3220 3315 +95 Misses 546 546 - Partials 219 251 +32 ``` | [Impacted Files](https://codecov.io/gh/libsv/go-bt/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv) | Coverage Δ | | |---|---|---| | [ord/2dummies.go](https://codecov.io/gh/libsv/go-bt/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-b3JkLzJkdW1taWVzLmdv) | `51.77% <56.52%> (ø)` | | | [ord/bid.go](https://codecov.io/gh/libsv/go-bt/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-b3JkL2JpZC5nbw==) | `59.57% <59.57%> (ø)` | | | [ord/list.go](https://codecov.io/gh/libsv/go-bt/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-b3JkL2xpc3QuZ28=) | `54.43% <68.42%> (ø)` | | | [bscript/script.go](https://codecov.io/gh/libsv/go-bt/pull/149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv#diff-YnNjcmlwdC9zY3JpcHQuZ28=) | `66.78% <75.00%> (+7.19%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libsv)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.