libtcod / python-tcod

A high-performance Python port of libtcod. Includes the libtcodpy module for backwards compatibility with older projects.
BSD 2-Clause "Simplified" License
410 stars 36 forks source link

fix rctrl assignment #47

Closed joshgcampbell closed 6 years ago

joshgcampbell commented 6 years ago

rctrl will always mirror lctrl right now. here's a quick fix.

>>> import tcod
>>> g_key = tcod.Key(pressed=True, vk=tcod.KEY_CHAR, c=ord('g'), lctrl=True, rctrl=False)
>>> print(g_key.rctrl)
True
HexDecimal commented 6 years ago

Looks like I typo'd all of the right-hand modifiers actually.

joshgcampbell commented 6 years ago

Ah yep, here's those too!

HexDecimal commented 6 years ago

Mind if you noted this fix in the changelog and rebased this into one commit? Then I'll merge.

HexDecimal commented 6 years ago

That might be too advanced. You just need to add to the changelog, or I can just take it from here if you want.

joshgcampbell commented 6 years ago

No worries. I gave it a shot. Let me know if this works.

HexDecimal commented 6 years ago

You did well. I'll merge sometime after integration tests pass. You might want to amend a missing space to your commit message.

codecov-io commented 6 years ago

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          20       20           
  Lines        3005     3005           
=======================================
  Hits         2625     2625           
  Misses        380      380
Impacted Files Coverage Δ
tcod/libtcodpy.py 93.32% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5926ca...9f2522c. Read the comment docs.

joshgcampbell commented 6 years ago

Awesome. I took care of that. Thank you!

HexDecimal commented 6 years ago

I'm guessing you might have a project that requires this fix. Want me to make a new release?

joshgcampbell commented 6 years ago

Thanks for asking @HexDecimal. I have a workaround in my project for now. Feel free to release whenever's convenient for you.

HexDecimal commented 6 years ago

Version 6.0.4 has your fix and will be fully deployed in about half an hour.