Closed joshgcampbell closed 6 years ago
Looks like I typo'd all of the right-hand modifiers actually.
Ah yep, here's those too!
Mind if you noted this fix in the changelog and rebased this into one commit? Then I'll merge.
That might be too advanced. You just need to add to the changelog, or I can just take it from here if you want.
No worries. I gave it a shot. Let me know if this works.
You did well. I'll merge sometime after integration tests pass. You might want to amend a missing space to your commit message.
Merging #47 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 20 20
Lines 3005 3005
=======================================
Hits 2625 2625
Misses 380 380
Impacted Files | Coverage Δ | |
---|---|---|
tcod/libtcodpy.py | 93.32% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e5926ca...9f2522c. Read the comment docs.
Awesome. I took care of that. Thank you!
I'm guessing you might have a project that requires this fix. Want me to make a new release?
Thanks for asking @HexDecimal. I have a workaround in my project for now. Feel free to release whenever's convenient for you.
Version 6.0.4 has your fix and will be fully deployed in about half an hour.
rctrl
will always mirrorlctrl
right now. here's a quick fix.