search

libtom / libtomcrypt

LibTomCrypt is a fairly comprehensive, modular and portable cryptographic toolkit that provides developers with a vast array of well known published block ciphers, one-way hash functions, chaining modes, pseudo-random number generators, public key cryptography and a plethora of other routines.
https://www.libtom.net
Other
1.57k stars 458 forks source link

Some MSVC warnings (just FYI) #501

Open karel-m opened 5 years ago

karel-m commented 5 years ago

Visual Studio 2008 (32bit build):

1>padding_pad.c
1>d:\git\libtomcrypt\src\misc\padding\padding_pad.c(126) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data
1>d:\git\libtomcrypt\src\misc\padding\padding_pad.c(131) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data
1>tweetnacl.c
1>d:\git\libtomcrypt\src\pk\ec25519\tweetnacl.c(96) : warning C4244: '=' : conversion from 'i64' to 'u8', possible loss of data
1>d:\git\libtomcrypt\src\pk\ec25519\tweetnacl.c(190) : warning C4244: 'function' : conversion from 'i64' to 'int', possible loss of data
1>d:\git\libtomcrypt\src\pk\ec25519\tweetnacl.c(191) : warning C4244: 'function' : conversion from 'i64' to 'int', possible loss of data
1>d:\git\libtomcrypt\src\pk\ec25519\tweetnacl.c(210) : warning C4244: 'function' : conversion from 'i64' to 'int', possible loss of data
1>d:\git\libtomcrypt\src\pk\ec25519\tweetnacl.c(211) : warning C4244: 'function' : conversion from 'i64' to 'int', possible loss of data
1>d:\git\libtomcrypt\src\pk\ec25519\tweetnacl.c(239) : warning C4244: 'function' : conversion from 'u64' to 'unsigned long', possible loss of data
1>d:\git\libtomcrypt\src\pk\ec25519\tweetnacl.c(466) : warning C4244: 'function' : conversion from 'u64' to 'size_t', possible loss of data
1>d:\git\libtomcrypt\src\pk\ec25519\tweetnacl.c(480) : warning C4244: 'function' : conversion from 'u64' to 'size_t', possible loss of data
1>d:\git\libtomcrypt\src\pk\ec25519\tweetnacl.c(485) : warning C4244: 'function' : conversion from 'u64' to 'size_t', possible loss of data
1>ed25519_sign.c
1>d:\git\libtomcrypt\src\pk\ed25519\ed25519_sign.c(48) : warning C4244: 'function' : conversion from 'unsigned __int64' to 'size_t', possible loss of data
1>ed25519_verify.c
1>d:\git\libtomcrypt\src\pk\ed25519\ed25519_verify.c(48) : warning C4244: 'function' : conversion from 'unsigned __int64' to 'size_t', possible loss of data
1>fortuna.c
1>d:\git\libtomcrypt\src\prngs\fortuna.c(240) : warning C4244: '=' : conversion from 'ulong64' to 'unsigned long', possible loss of data
1>chacha_memory.c
1>d:\git\libtomcrypt\src\stream\chacha\chacha_memory.c(37) : warning C4244: 'function' : conversion from 'ulong64' to 'ulong32', possible loss of data

Visual Studio 2008 (64bit build):

1>padding_pad.c
1>.\src\misc\padding\padding_pad.c(126) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data
1>.\src\misc\padding\padding_pad.c(131) : warning C4244: '=' : conversion from 'unsigned long' to 'unsigned char', possible loss of data
1>ssh_encode_sequence_multi.c
1>.\src\misc\ssh\ssh_encode_sequence_multi.c(63) : warning C4267: '+=' : conversion from 'size_t' to 'ulong32', possible loss of data
1>.\src\misc\ssh\ssh_encode_sequence_multi.c(121) : warning C4267: '=' : conversion from 'size_t' to 'ulong32', possible loss of data
1>pk_oid_str.c
1>.\src\pk\asn1\oid\pk_oid_str.c(24) : warning C4267: '=' : conversion from 'size_t' to 'unsigned long', possible loss of data
1>tweetnacl.c
1>.\src\pk\ec25519\tweetnacl.c(96) : warning C4244: '=' : conversion from 'i64' to 'u8', possible loss of data
1>.\src\pk\ec25519\tweetnacl.c(190) : warning C4244: 'function' : conversion from 'i64' to 'int', possible loss of data
1>.\src\pk\ec25519\tweetnacl.c(191) : warning C4244: 'function' : conversion from 'i64' to 'int', possible loss of data
1>.\src\pk\ec25519\tweetnacl.c(210) : warning C4244: 'function' : conversion from 'i64' to 'int', possible loss of data
1>.\src\pk\ec25519\tweetnacl.c(211) : warning C4244: 'function' : conversion from 'i64' to 'int', possible loss of data
1>.\src\pk\ec25519\tweetnacl.c(239) : warning C4244: 'function' : conversion from 'u64' to 'unsigned long', possible loss of data
1>fortuna.c
1>.\src\prngs\fortuna.c(240) : warning C4244: '=' : conversion from 'ulong64' to 'unsigned long', possible loss of data
1>chacha_memory.c
1>.\src\stream\chacha\chacha_memory.c(37) : warning C4244: 'function' : conversion from 'ulong64' to 'ulong32', possible loss of data

@sjaeckel feel free to pick some (or none) of them for fixing and close this issue.

sjaeckel commented 5 years ago

The AppVeyor builds show them as well...

karel-m commented 5 years ago

What about adding /WX (= treat all warnings as error)?

sjaeckel commented 5 years ago

What about adding /WX (= treat all warnings as error)?

as soon as they're fixed, sure - why not!