add chinese standard GM symmetric crypto SM4.

libtom / libtomcrypt

LibTomCrypt is a fairly comprehensive, modular and portable cryptographic toolkit that provides developers with a vast array of well known published block ciphers, one-way hash functions, chaining modes, pseudo-random number generators, public key cryptography and a plethora of other routines.

https://www.libtom.net

Other

1.55k stars 457 forks source link

add chinese standard GM symmetric crypto SM4. #563

Closed mogoweb closed 2 years ago

mogoweb commented 3 years ago

about chinese standard GM documents, please refer to https://github.com/guanzhi/GM-Standards.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

karel-m commented 3 years ago

I am afraid the code in this PR does not comply with libtomcrypt licence.

karel-m commented 3 years ago

Plus the standardization of SM4 got stuck in 2018 https://tools.ietf.org/html/draft-ribose-cfrg-sm4-10

I vote for rejecting this PR.

tyzoid commented 2 years ago

I second @karel-m 's reasoning - rejection is the only available resolution here, unless we're willing to accept a reimplementation unencumbered by its license.