Closed jforissier closed 1 year ago
I've added that testcase and I hope that the implicit re-licensing is OK! If not I won't merge the PR.
~I'm still waiting for the CI to finish, but my local build succeeds~ CI is green now ... :grimacing: ... maybe this is caused by something else?
Well, I can confirm that reverting the value to 512 makes the test pass on my side... But of course it doesn't mean there isn't something else (we do carry a few local patches on top of upstream libromcrypt in OP-TEE). I will definitely take a closer look on my side. As for the licensing of the test vector, I don't think there is any issue since it comes straight from the NIST test suite.
Thanks for your quick reply, I'll keep you posted.
Well the bug is actually in OP-TEE which passes a DSA key with a wrong .qord
. @sjaeckel sorry for the noise :confused:
I hope this only uncovered a bug in your tests :)
Hi,
Re. https://github.com/libtom/libtomcrypt/pull/546#issuecomment-817942961
The new value of
LTC_MDSA_MAX_GROUP
makes our test suite fail:https://github.com/OP-TEE/optee_test/blob/3.18.0/host/xtest/regression_4000.c#L3096
For the test vector, see https://raw.githubusercontent.com/OP-TEE/optee_test/3.18.0/host/xtest/nist/186-3dsatestvectors.h and search for
ac_dsa_vect106
.