search

libtom / libtomcrypt

LibTomCrypt is a fairly comprehensive, modular and portable cryptographic toolkit that provides developers with a vast array of well known published block ciphers, one-way hash functions, chaining modes, pseudo-random number generators, public key cryptography and a plethora of other routines.
https://www.libtom.net
Other
1.51k stars 449 forks source link

Custom LIBPATH is not reflected in libtomcrypt.pc #625

Closed levitte closed 10 months ago

levitte commented 11 months ago

This was discovered by looking at Debian's package, where they create an installation like this:

$(MAKE) DESTDIR=$(CURDIR)/debian/tmp INSTALL_GROUP=root LIBPATH=/usr/lib/$(DEB_HOST_MULTIARCH) PREFIX=/usr install -f makefile.share

In my case, DEB_HOST_MULTIARCH = x86_64-linux-gnu, which makes complete sense with regards to Debian policies. However, because libtomcrypt.pc.in has a hard coded libdir=${exec_prefix}/lib, the resulting system pkg-config (/usr/lib/x86_64-linux-gnu/pkgconfig/libtommath.pc) isn't useful.

sjaeckel commented 11 months ago

Can you please check whether this fixes the issue for you?

sjaeckel commented 11 months ago

Ping @levitte

levitte commented 11 months ago

I'm not in a position to actually test it, but from just eyeballing, it looks right to me. I can do tests next week.