Simplify AES-NI detection logic

libtom / libtomcrypt

LibTomCrypt is a fairly comprehensive, modular and portable cryptographic toolkit that provides developers with a vast array of well known published block ciphers, one-way hash functions, chaining modes, pseudo-random number generators, public key cryptography and a plethora of other routines.

https://www.libtom.net

Other

1.51k stars 449 forks source link

Simplify AES-NI detection logic #641

Open sjaeckel opened 4 months ago

sjaeckel commented 4 months ago

Based on the patch provided by @thesamesam via [0], but slighly modified.

@thesamesam could you maybe test whether this patch is fine as well?

[0] https://github.com/DCIT/perl-CryptX/pull/99

thesamesam commented 4 months ago

Let me have a go. Thanks!

I don't remember if I managed to reproduce the original problem or if I was just able to reason it out, let's see ;)

@hannob Could you try it out on your machine which hit the original Gentoo bug too?

hannob commented 2 months ago

FWIW as @thesamesam asked me to try to reproduce: I can confirm that with this patch I can build libtomcrypt. I can also build CryptX (patch needs a small adaption).

But I should also point out that I was unable to reproduce the error I got with CryptX in plain libtomcrypt.