search

libtom / libtommath

LibTomMath is a free open source portable number theoretic multiple-precision integer library written entirely in C.
https://www.libtom.net
Other
650 stars 194 forks source link

Makefiles missing "--tag=CC" in targets for tests #152

Closed danieagle closed 5 years ago

danieagle commented 5 years ago

allmost all targets for tests in some makefiles are missing --tag=CC

e.g:

$ make -f makefile.shared test

libtool --mode=link cc -o test demo/demo.o libtommath.la libtool: link: unable to infer tagged configuration libtool: error: specify a tag with '--tag'

System: AMD64 linux Ubuntu 'Disco' gcc-8.2.0 (Ubuntu 8.2.0-15ubuntu1) libtool 2.4.6 Debian-2.4.6-9

Very Very Very Thanks for yours continued excelent work! :-)

[]'s Dani.

dod38fr commented 5 years ago

I think that the tests should be run this way on Debian and derivatives:

make -f makefile.shared 
make test_standalone
./test

This sequence is working on my Debian system and will soon be used while building libtommath for Debian (thanks @sjaeckel for the hint)

Hope this helps

sjaeckel commented 5 years ago

I think that the tests should be run this way on Debian and derivatives:

make -f makefile.shared 
make test_standalone
./test

This sequence is working on my Debian system and will soon be used while building libtommath for Debian (thanks @sjaeckel for the hint)

I guess that will mix things up, it should work most of the but it's not guaranteed

make -f makefile.shared 
make -f makefile.shared test_standalone
./test

should be the way to do it IMO

sjaeckel commented 5 years ago

should be the way to do it IMO

aaaand that's the one that triggers this issue *bam*

czurnieden commented 5 years ago

That error comes up if $CC is set to something different from what libtool expected or not set at all.

danieagle commented 5 years ago

Hi!

I'll verify and report.

()'s Dani.

Em qui, 31 de jan de 2019 10:59, Dominique Dumont <notifications@github.com escreveu:

I think that the tests should be run this way on Debian and derivatives:

make -f makefile.shared make test_standalone ./test

This sequence is working on my Debian system and will soon be used while building libtommath for Debian (thanks @sjaeckel https://github.com/sjaeckel for the hint)

Hope this helps

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/libtom/libtommath/issues/152#issuecomment-459335191, or mute the thread https://github.com/notifications/unsubscribe-auth/AMW9VFSUZ_pLg45TQ9InastM87SbZOqWks5vIujBgaJpZM4acM8z .

sjaeckel commented 5 years ago

can you please try the code from #153

danieagle commented 5 years ago

the #153 Worked! :-)

Very Very Very Thanks!!!

[]'s Dani. :-)

Em qui, 31 de jan de 2019 às 11:12, Steffen Jaeckel < notifications@github.com> escreveu:

can you please try the code from #153 https://github.com/libtom/libtommath/pull/153

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/libtom/libtommath/issues/152#issuecomment-459339052, or mute the thread https://github.com/notifications/unsubscribe-auth/AMW9VObCF7eXBPK6qgD7E2OHsBgbKooPks5vIuvbgaJpZM4acM8z .

-- "There are many plans in the Human heart, But is the Lord's Purpose that prevails"

"Existem Muitos planos e desejos no coração Humano, MAS são os Propósitos do Senhor que prevalecem"

[]'s Dani:-)